datadog_monitor: kwargs for _update_monitor used message vs notification_message #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asciifaceman
changed the title
|
Note: I don't understand the ansible/third-party-check that failed, but would be happy to correct anything if it is on my end |
|
@asciifaceman you can ignore the third-party-check, I think it is still under development. |
changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml
Outdated
Show resolved
Hide resolved
…essage-param.yml Co-authored-by: Felix Fontein <[email protected]>
gundalow
approved these changes
May 28, 2020
|
Merged Felix, thank you as always for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Noticed that
datadog_monitor.pyhad not updated_update_monitorto usenotification_messagewhich deprecatedmessagedue to being a reserved keyword.This PR makes that small correction.
ISSUE TYPE
COMPONENT NAME
Monitoring / datadog_monitor
ADDITIONAL INFORMATION
before:
after:
works as expected