From 73e53a9b479258c111bd03038bbeff4263f92dff Mon Sep 17 00:00:00 2001 From: "charles.corbett@wurl.com" Date: Wed, 20 May 2020 14:12:32 -0700 Subject: [PATCH 1/3] kwargs for _update_monitor wasn't corrected to new notification_message param --- plugins/modules/monitoring/datadog/datadog_monitor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/monitoring/datadog/datadog_monitor.py b/plugins/modules/monitoring/datadog/datadog_monitor.py index e14081b3070..64a69987d0f 100644 --- a/plugins/modules/monitoring/datadog/datadog_monitor.py +++ b/plugins/modules/monitoring/datadog/datadog_monitor.py @@ -301,7 +301,7 @@ def _update_monitor(module, monitor, options): try: kwargs = dict(id=monitor['id'], query=module.params['query'], name=_fix_template_vars(module.params['name']), - message=_fix_template_vars(module.params['message']), + message=_fix_template_vars(module.params['notification_message']), escalation_message=_fix_template_vars(module.params['escalation_message']), options=options) if module.params['tags'] is not None: From 6175fd5c5349c2f035e7462cd7288b12c295be8a Mon Sep 17 00:00:00 2001 From: "charles.corbett@wurl.com" Date: Wed, 20 May 2020 14:17:30 -0700 Subject: [PATCH 2/3] forgot to bump a changelog fragment --- .../389-datadog_monitor-corrects-deprecated-message-param.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml diff --git a/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml b/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml new file mode 100644 index 00000000000..1383105d201 --- /dev/null +++ b/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml @@ -0,0 +1,2 @@ +bugfixes: + - datadog_monitor - Corrects ``_update_monitor`` to use ``notification_message`` insteade of deprecated ``message`` \ No newline at end of file From fa9b08fec8ed233b7b3d576cd346b42e10b93c1a Mon Sep 17 00:00:00 2001 From: Charles C Date: Thu, 21 May 2020 10:36:37 -0700 Subject: [PATCH 3/3] Update changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml Co-authored-by: Felix Fontein --- .../389-datadog_monitor-corrects-deprecated-message-param.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml b/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml index 1383105d201..db8c6e2448e 100644 --- a/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml +++ b/changelogs/fragments/389-datadog_monitor-corrects-deprecated-message-param.yml @@ -1,2 +1,2 @@ bugfixes: - - datadog_monitor - Corrects ``_update_monitor`` to use ``notification_message`` insteade of deprecated ``message`` \ No newline at end of file + - datadog_monitor - Corrects ``_update_monitor`` to use ``notification_message`` insteade of deprecated ``message`` (https://github.com/ansible-collections/community.general/pull/389).