parted option align: undefined to maintain parted 1.8.3 compatibility

[rosowiecki]

SUMMARY

Added option align: undefined to support parted versions < 2.1

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

parted

ADDITIONAL INFORMATION

I've actually tested parted 1.8.3 on some ancient system, but it failed. The reason was that -a option was added in parted 2.1.

Alternative solutions:

• omit -a option for 'optimal' (parted's default setting is 'optimal' too, works in my patched ansible 2.7)
• update required version of parted to 2.1 instead

[ansibullbot]

cc @ColOfAbRiX @MorrisA @bcoca @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @wtcross
click here for bot help

[rosowiecki]

I couldn'd find what's special about 1.8.3 version anyway? Maybe it should be just 1.8... (@ColOfAbRiX, what do you think?)

[rosowiecki]

Regarding Zuul tests failure: #402

[ColOfAbRiX]

I'm trying to understand if we're still supposed to support parted 1.8, I'm going to write down my notes as I look up for things.

At the moment the earlier maintained version of Ansible is 2.7 (https://docs.ansible.com/ansible/2.9/reference_appendices/release_and_maintenance.html#release-status)

Ansible 2.7 must support Python 2.6 on the managed nodes (https://docs.ansible.com/ansible/2.7/installation_guide/intro_installation.html#managed-node-requirements)

Python 2.6 was released in 2008 (https://www.python.org/downloads/release/python-260/)

Parted 1.8.3 was released in 2007 (http://freshmeat.sourceforge.net/projects/gnuparted/releases), Parted 2.0 in 2009 (https://git.savannah.gnu.org/cgit/parted.git/tag/?h=v2.0)

Result
When Python 2.6 was out probably the majority of systems were still using parted 1.8.3. So I would say we still have to support parted 1.8.3.

I think the way you've done in this PR is the correct way

[pabelanger]

recheck

[felixfontein]

Please add a changelog fragment. Then I think this can be merged (as @ColOfAbRiX seems to approve).

[felixfontein]

LGTM