passwordstore: Fix error detection for non-English locales #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
grembo
force-pushed
the
passwordstore-locale
branch
2 times, most recently
from
3325d23 to
f5fe4f1
Compare
The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html
grembo
force-pushed
the
passwordstore-locale
branch
from
f5fe4f1 to
e066025
Compare
felixfontein
approved these changes
Feb 17, 2022
felixfontein
added
backport-3
check-before-release
felixfontein
removed
the
check-before-release
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #4220 🤖 @patchback |
|
@grembo thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html (cherry picked from commit 77a0c13)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4221 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html (cherry picked from commit 77a0c13)
felixfontein
pushed a commit
that referenced
this pull request
Feb 17, 2022
…4220) The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html (cherry picked from commit 77a0c13) Co-authored-by: grembo <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Feb 17, 2022
…4221) The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html (cherry picked from commit 77a0c13) Co-authored-by: grembo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The passwordstore lookup plugin depends on parsing GnuPG's
error messages in English language. As a result, detection of
a specific error failes when users set a different locale.
This change corrects this by setting the
LANGUAGEenvironmentvariable to
Cwhen invokingpass, as this only affectsgettext translations.
See
https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html
ISSUE TYPE
COMPONENT NAME
passwordstore
plugins/lookup/passwordstore
ADDITIONAL INFORMATION
Originally discussed in #4912