-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pritunl] add mac_addresses parameter #4535
[pritunl] add mac_addresses parameter #4535
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some first comments.
changelogs/fragments/4535-pritunl-add-mac_addresses-parameter.yml
Outdated
Show resolved
Hide resolved
Does line 218 also needs to be adjusted? |
Sorry for delay, I'll test today. |
@vvatlin this PR contains the following merge commits: Please rebase your branch to remove these commits. |
@felixfontein yes you are right, I've added the check to the 218 also. |
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
657f116
to
ffa2c9e
Compare
Looks good to me. @Lowess what do you think? |
I'll merge beginning of next week if nobody complains. |
@vvatlin thanks for your contribution! |
SUMMARY
Pritunl VPN supports to limit user by his MAC addresses, added this parameter to the module
ISSUE TYPE
COMPONENT NAME
pritunl
ADDITIONAL INFORMATION