Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pritunl] add mac_addresses parameter #4535

Merged
merged 10 commits into from
May 9, 2022

Conversation

vvatlin
Copy link
Contributor

@vvatlin vvatlin commented Apr 20, 2022

SUMMARY

Pritunl VPN supports to limit user by his MAC addresses, added this parameter to the module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pritunl

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @Lowess
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Apr 20, 2022
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 20, 2022
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-4 labels Apr 20, 2022
@ansibullbot ansibullbot removed the new_contributor Help guide this first time contributor label Apr 20, 2022
@felixfontein
Copy link
Collaborator

Does line 218 also needs to be adjusted?

@vvatlin
Copy link
Contributor Author

vvatlin commented Apr 26, 2022

Sorry for delay, I'll test today.

@ansibullbot
Copy link
Collaborator

@vvatlin this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 27, 2022
@vvatlin
Copy link
Contributor Author

vvatlin commented Apr 27, 2022

@felixfontein yes you are right, I've added the check to the 218 also.

@vvatlin vvatlin force-pushed the add_mac_address_option branch from 657f116 to ffa2c9e Compare April 28, 2022 12:16
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 28, 2022
@felixfontein
Copy link
Collaborator

Looks good to me.

@Lowess what do you think?

@felixfontein
Copy link
Collaborator

I'll merge beginning of next week if nobody complains.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 9, 2022
@felixfontein felixfontein merged commit cf55ef8 into ansible-collections:main May 9, 2022
@felixfontein
Copy link
Collaborator

@vvatlin thanks for your contribution!

@vvatlin vvatlin deleted the add_mac_address_option branch May 10, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module net_tools plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants