[PR #4640/9e1af2d1 backport][stable-3] onepassword - Get first found config file #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Get first found configuration file There are three valid places to get the configuration. https://developer.1password.com/docs/cli/about-biometric-unlock#remove-old-account-information * Use common config class * Add changelog fragment * Explicitly use new style classes for Python 2.7 compatibility This shouldn’t matter for lookups, but does matter for module_utils and modules since Python 2.7 is still supported on the managed node. * Update changelogs/fragments/4065-onepassword-config.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 9e1af2d)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-3/9e1af2d1bce7b30995b46a2fa2992a054c507e3a/pr-4640
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4640 as merged into main (9e1af2d).
SUMMARY
Fixes #4065.
There are three configuration file locations. Use the first found valid config.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/onepassword.pyplugins/module_utils/onepassword.pyplugins/modules/identity/onepassword_info.pyADDITIONAL INFORMATION
This plugin is currently broken since the 1Password v2 CLI was released. More work is needed to address that issue, but this is a first step.