-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slackpkg: fix matching some special cases in package names. #505
slackpkg: fix matching some special cases in package names. #505
Conversation
Looks good to me. @KimNorgaard could you please take a look? |
changelogs/fragments/505-slackpkg_fix_matching_some_special_cases_in_package_names.yml
Outdated
Show resolved
Hide resolved
…ses_in_package_names.yml Co-authored-by: Andrew Klychkov <[email protected]>
@majekw do you want to continue to work on this, or should we merge it? |
It's ready to merge. |
I'll wait a bit more so that @KimNorgaard can take a look when possible. |
Looks good |
@majekw @Andersson007 @KimNorgaard thanks a lot! |
SUMMARY
There are some special cases in Slackware package naming which are not covered by
$ARCH|noarch
condition:kernel-headers
has architecture set tox86
onx86_64
fw
This PR adds check for
kernel-headers
special case and addsfw
to other expected architectures.ISSUE TYPE
COMPONENT NAME
slackpkg.py
ADDITIONAL INFORMATION
For example, try to install package
kernel-headers
.Module runs
slackpkg install kernel-headers
(installs it if package is not present), then check is run if package is installed, but it can't find it because architecture part of package name is different (x86
instead of expectedx86_64
) and task fails.Similar thing for firmware files, for example
zd1211-firmware-1.4-fw-1
. It fails because architecture part is set tofw
and doesn't match current condition.Example output from system where
kernel-headers
are already installed