Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5680/488e828f backport][stable-6] ansible_galaxy_install: use locale C tentatively, else en_US #5722

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 22, 2022

This is a backport of PR #5680 as merged into main (488e828).

SUMMARY

Tries to use locale C.UTF-8, if that fails then fall back to en_US.UTF-8.

Fixes #5661

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible_galaxy_install

* ansible_galaxy_install: use locale C tentatively, else en_US

* use custom exception to signal unsupported locale

* add step to remove artefacts at the end of the test

* add step to remove artefacts at the beginning of the test

* comment out context controller

* trying with temporary dir as destination

* remove collection before test with reqs file

* ensure collections are installed in temp dir in tests + check_force

* simplified the change

* added extra condition for failing locale

* improved exception handling

* add changelog fragment

(cherry picked from commit 488e828)
@ansibullbot
Copy link
Collaborator

cc @russoz
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests labels Dec 22, 2022
@felixfontein felixfontein merged commit 6037c5d into stable-6 Dec 22, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-6/488e828f9b7dcf2867edec72ce35f766d7b54ff0/pr-5680 branch December 22, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants