Add support to Bitwarden Lookup for filtering results by collection (#5849) #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
lookup
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
needs_ci
felixfontein
added
check-before-release
There was a problem hiding this comment.
Thanks for your contribution. Could you please add a changelog fragment? Thanks.
|
@felixfontein thanks for review and hints what's needed :) I added changelog fragment and adjusted code as you proposed. |
ansibullbot
added
tests
changelogs/fragments/5851-lookup-bitwarden-add-filter-by-collection-id-parameter.yml
Outdated
Show resolved
Hide resolved
|
@felixfontein no worries, I adjusted code as proposed, thanks :) |
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
merge_commit
ansibullbot
removed
merge_commit
felixfontein
approved these changes
Jan 18, 2023
|
If nobody objects I'll merge this in ~one week. |
|
There are now conflicts in this PR since I merged #5811 (a line adjacent to one changed in this PR was changed). Can you please rebase your PR against the latest |
ansibullbot
added
needs_rebase
|
Sorry for late update, it's done @felixfontein |
ansibullbot
removed
needs_rebase
felixfontein
approved these changes
Jan 26, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5904 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Jan 28, 2023
…5849) (#5851) * Add support to Bitwarden Lookup for filtering results by collection id (#5849) * Debug * Add support to Bitwarden Lookup for filtering results by collection id (#5849) * Update comments * Fix blank line issue * Fix unit tests for bitwarden lookup plugin. Add changelog fragment file. * Change collectionId to collection_id parameter on bitwarden plugin * Fix collection id parameter name when used in bw cli (cherry picked from commit 7b8b73f)
|
@psalkowski thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jan 28, 2023
…p for filtering results by collection (#5849) (#5904) Add support to Bitwarden Lookup for filtering results by collection (#5849) (#5851) * Add support to Bitwarden Lookup for filtering results by collection id (#5849) * Debug * Add support to Bitwarden Lookup for filtering results by collection id (#5849) * Update comments * Fix blank line issue * Fix unit tests for bitwarden lookup plugin. Add changelog fragment file. * Change collectionId to collection_id parameter on bitwarden plugin * Fix collection id parameter name when used in bw cli (cherry picked from commit 7b8b73f) Co-authored-by: Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to filter search results from bit warden by collection id. If collection id is not provided, bit warden cli will not use any filtering