-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection #5903
Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection #5903
Conversation
…ce root and POST to the session collection
changelogs/fragments/5886-redfish-correct-basic-auth-usage-on-session-creation.yml
Outdated
Show resolved
Hide resolved
…session-creation.yml Co-authored-by: Felix Fontein <[email protected]>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5923 🤖 @patchback |
…ce root and POST to the session collection (#5903) * Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection * Update changelogs/fragments/5886-redfish-correct-basic-auth-usage-on-session-creation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea5cbe2)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5924 🤖 @patchback |
@mraineri thanks a lot for your contribution! |
…ce root and POST to the session collection (#5903) * Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection * Update changelogs/fragments/5886-redfish-correct-basic-auth-usage-on-session-creation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea5cbe2)
…ader when performing a GET on the service root and POST to the session collection (#5923) Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection (#5903) * Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection * Update changelogs/fragments/5886-redfish-correct-basic-auth-usage-on-session-creation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea5cbe2) Co-authored-by: Mike Raineri <[email protected]>
…ader when performing a GET on the service root and POST to the session collection (#5924) Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection (#5903) * Redfish: Removed basic auth header when performing a GET on the service root and POST to the session collection * Update changelogs/fragments/5886-redfish-correct-basic-auth-usage-on-session-creation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea5cbe2) Co-authored-by: Mike Raineri <[email protected]>
SUMMARY
Redfish services do not expect authorization headers when performing a POST to the session collection. The expectation is credentials are in the request body. While the specification is silent on how services behave when authorization headers are present in this request, the guidance for clients is to not provide the header.
The change here removes the authorization header on two conditions:
Fix #5886
ISSUE TYPE
COMPONENT NAME
redfish_utils
ADDITIONAL INFORMATION
On some systems, using the Redfish command "CreateSessions" will result in an error (as shown in #5886).
Before:
After: