Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mode has only been added for some _info and _facts modules in a bugfix #5969

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Document the version when check mode was added for these modules (was done in #3084).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

some _info and _facts modules

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 17, 2023
@felixfontein felixfontein merged commit 867aee6 into ansible-collections:main Feb 20, 2023
@patchback
Copy link

patchback bot commented Feb 20, 2023

Beep beep boop!
🤖 Hi, I'm @patchback — your friendly neighborhood robot!

Somebody's just asked me to create a backport of this pull request
into the stable-6 branch. So in this comment I report that
I'm on it!

Please, expect to see further updates regarding my progress in updates
to this comment. Stay tuned!

If you think I'm experiencing problems, ping @webknjaz — my creator.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 20, 2023

Backport to stable-6: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 867aee6 on top of patchback/backports/stable-6/867aee606e42ad52e8ea653d890397b033c8bf7d/pr-5969

Backporting merged PR #5969 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-6/867aee606e42ad52e8ea653d890397b033c8bf7d/pr-5969 upstream/stable-6
  4. Now, cherry-pick PR Check mode has only been added for some _info and _facts modules in a bugfix #5969 contents into that branch:
    $ git cherry-pick -x 867aee606e42ad52e8ea653d890397b033c8bf7d
    If it'll yell at you with something like fatal: Commit 867aee606e42ad52e8ea653d890397b033c8bf7d is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x 867aee606e42ad52e8ea653d890397b033c8bf7d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Check mode has only been added for some _info and _facts modules in a bugfix #5969 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-6/867aee606e42ad52e8ea653d890397b033c8bf7d/pr-5969
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein added a commit to felixfontein/community.general that referenced this pull request Feb 20, 2023
… bugfix (ansible-collections#5969)

Check mode has only been added for some _info and _facts modules in a bugfix.

(cherry picked from commit 867aee6)
felixfontein added a commit that referenced this pull request Feb 20, 2023
…odules in a bugfix (#6026)

Check mode has only been added for some _info and _facts modules in a bugfix (#5969)

Check mode has only been added for some _info and _facts modules in a bugfix.

(cherry picked from commit 867aee6)
jikamens pushed a commit to jikamens/community.general that referenced this pull request Feb 25, 2023
… bugfix (ansible-collections#5969)

Check mode has only been added for some _info and _facts modules in a bugfix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants