[PR #5829/4c4ef80c backport][stable-6] yarn: Fix state=latest not working with global=true #5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Yarn module: fix state=latest not working with global=true * fix whitespace * add changelog fragment * add integration test cases * add only tests for this PR (install+upgrade) * fix assuming default global dir * fix list() not working when global=true and name a package with no binary * remove ignores * whitespace * Update changelogs/fragments/5829-fix-yarn-global.yml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/5829-fix-yarn-global.yml Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 4c4ef80)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-6/4c4ef80ca9518792bc4e0551864a7929254a27a0/pr-5829
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5829 as merged into main (4c4ef80).
SUMMARY
Fixes #5712.
_execto support running Yarn commands that wouldn't ordinarily be available withyarn globalby setting the working directory to the path fromyarn global dirinstead.list_outdatedto use this new functionality when invokingyarn outdated.list_outdatedto check for actual errors in stderr output instead of failing on the presence of anything in stderr. This is b/c the Yarn global package.json has no license field, causing a warning to be logged to stderr when invokingyarn outdatedin that directory.Through testing, found a couple more related bugs to fix (see comments below):
DEFAULT_GLOBAL_INSTALLATION_PATHwith code to check the output ofyarn global dir, as the default path may be different when the use is root, or when the user has set YARN_GLOBAL_FOLDER or the corresponding config flag.listto function correctly for packages without binaries (regular libraries) when global=true by invokingyarn listwithoutglobal, the same way I did foryarn outdatedabove.And finally, added tests for all the above cases. Previously, there were no tests for
global=trueat all.ISSUE TYPE
COMPONENT NAME
yarn
ADDITIONAL INFORMATION
Before:
After: