Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5994/1877ef15 backport][stable-5] github_webhook: Don't include secret in the config if it's absent #6087

Merged
merged 1 commit into from
Feb 25, 2023
Merged

[PR #5994/1877ef15 backport][stable-5] github_webhook: Don't include secret in the config if it's absent #6087

merged 1 commit into from
Feb 25, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 25, 2023

This is a backport of PR #5994 as merged into main (1877ef1).

SUMMARY

Currently if you don't have a secret for the hook, the module will always report changed status even after multiple runs. This change adds secret to the config only if user specifies it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

github_webhook

ADDITIONAL INFORMATION

I've tested the change locally:

  • if user doesn't provide secret - it doesn't report changed state anymore on the second run
  • if user provides empty secret - it doesn't report changed state anymore on the second run
  • if there was a secret before, and user doesn't provide a secret in the task - it will remove the secret (same as before this change)

@dima1206 @patchback
github_webhook: Don't include secret in the config if it's absent (#5994
04c47d1 
)

* github_webhook: Don't include secret in the config if it's absent

* Add changelogs

* Fix indentation

* Apply suggestion to simplify the check

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: dima1206 <�[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 1877ef1)
@patchback patchback bot mentioned this pull request Feb 25, 2023
Merged
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 25, 2023
@felixfontein felixfontein merged commit c3b1a3a into stable-5 Feb 25, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-5/1877ef1510175566c5ce08129929c0fe253d67ff/pr-5994 branch February 25, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @dima1206