Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: fixed idempotency issue when config bridge connection #6105

Merged
merged 2 commits into from
Mar 26, 2023
Merged

nmcli: fixed idempotency issue when config bridge connection #6105

merged 2 commits into from
Mar 26, 2023

Conversation

heaveaxy
Copy link
Contributor

SUMMARY

If bridge.stp is set to no in nmcli it accepts any value of bridge.priority but holds it's own default value. This causes any task with defined priority option to be "changed" anyway.

For now, bridge.priority participate in configure only when user defined stp as true.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nmcli

@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Feb 26, 2023
@heaveaxy heaveaxy mentioned this pull request Feb 26, 2023
Closed
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Feb 27, 2023
@ansibullbot ansibullbot added stale_ci CI is older than 7 days, rerun before merging and removed new_contributor Help guide this first time contributor labels Mar 7, 2023
This was referenced Mar 19, 2023
Merged
Merged
Merged
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this this weekend as well.

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Mar 25, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 26, 2023
@felixfontein felixfontein merged commit 81b16a8 into ansible-collections:main Mar 26, 2023
@patchback
Copy link

patchback bot commented Mar 26, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/81b16a88ee4d8e2433dca7f323e22bca2d37c6ac/pr-6105

Backported as #6242

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 26, 2023
@heaveaxy @patchback
nmcli: fixed idempotency issue when config bridge connection (#6105)
de3a2cb 
* nmcli: fixed idempotency issue when config bridge connection

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 81b16a8)
@patchback patchback bot mentioned this pull request Mar 26, 2023
Merged
@felixfontein
Copy link
Collaborator

@heaveaxy thanks for your contribution!

@patchback
Copy link

patchback bot commented Mar 26, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/81b16a88ee4d8e2433dca7f323e22bca2d37c6ac/pr-6105

Backported as #6243

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 26, 2023
@heaveaxy @patchback
nmcli: fixed idempotency issue when config bridge connection (#6105)
de04dad 
* nmcli: fixed idempotency issue when config bridge connection

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 81b16a8)
@patchback patchback bot mentioned this pull request Mar 26, 2023
Merged
felixfontein pushed a commit that referenced this pull request Mar 26, 2023
@patchback @heaveaxy
[PR #6105/81b16a88 backport][stable-5] nmcli: fixed idempotency issue…
3176c08 
… when config bridge connection (#6242)

nmcli: fixed idempotency issue when config bridge connection (#6105)

* nmcli: fixed idempotency issue when config bridge connection

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 81b16a8)

Co-authored-by: Sam Potekhin <[email protected]>
felixfontein pushed a commit that referenced this pull request Mar 26, 2023
@patchback @heaveaxy
[PR #6105/81b16a88 backport][stable-6] nmcli: fixed idempotency issue…
3432be3 
… when config bridge connection (#6243)

nmcli: fixed idempotency issue when config bridge connection (#6105)

* nmcli: fixed idempotency issue when config bridge connection

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 81b16a8)

Co-authored-by: Sam Potekhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module net_tools plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmcli bridge not idempotent
3 participants
@heaveaxy @ansibullbot @felixfontein