Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #6981/f9448574 backport][stable-7] [proxmox_kvm] Don't create VM if name is used without vmid #6992

Merged
merged 1 commit into from
Jul 23, 2023
Merged

[PR #6981/f9448574 backport][stable-7] [proxmox_kvm] Don't create VM if name is used without vmid #6992

merged 1 commit into from
Jul 23, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 23, 2023

This is a backport of PR #6981 as merged into main (f944857).

SUMMARY

Fixes #6911

While creating VM by using name only we check if VM with that name already exist and cluster and do nothing in that case.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

@UnderGreen @patchback
[proxmox_kvm] Don't create VM if name is used without vmid (#6981)
cdc3c61 
* [proxmox_kvm] Don't create VM if name is used without vmid

* Add changelog and unit tests

(cherry picked from commit f944857)
@patchback patchback bot mentioned this pull request Jul 23, 2023
Merged
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Jul 23, 2023
@felixfontein felixfontein merged commit 93f990a into stable-7 Jul 23, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/f9448574bd43611d71932f0d88bc67585d528f2f/pr-6981 branch July 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @UnderGreen