nsupdate: fix 'index out of range' error when no TTL answer is given #7219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves ansible-collections#836
silkeh
force-pushed
the
fix-dns-update-cname
branch
from
6f05078 to
7fe4621
Compare
ansibullbot
added
bug
felixfontein
reviewed
Sep 7, 2023
felixfontein
added
check-before-release
felixfontein
reviewed
Sep 8, 2023
| current_ttl = lookup.answer[0].ttl if lookup.answer else lookup.authority[0].ttl | ||
| else: | ||
| current_ttl = lookup.answer[0].ttl | ||
| current_ttl = lookup.answer[0].ttl if lookup.answer else lookup.authority[0].ttl |
There was a problem hiding this comment.
I don't know whether using the SOA TTL as a backup is a correct, but this should definitely help against the reported problems. The worst that can happen is that the module will always report changed instead of failing, which is already a big improvement.
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7235 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 10, 2023
…7219) * nsupdate: fix 'index out of range' error when no TTL answer is given Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves #836 * fixup! nsupdate: fix 'index out of range' error when no TTL answer is given (cherry picked from commit 208df2c)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7236 🤖 @patchback |
|
@silkeh thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 10, 2023
…7219) * nsupdate: fix 'index out of range' error when no TTL answer is given Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves #836 * fixup! nsupdate: fix 'index out of range' error when no TTL answer is given (cherry picked from commit 208df2c)
|
@felixfontein: thanks for the quick response! It is much appreciated. |
felixfontein
pushed a commit
that referenced
this pull request
Sep 11, 2023
…nge' error when no TTL answer is given (#7235) nsupdate: fix 'index out of range' error when no TTL answer is given (#7219) * nsupdate: fix 'index out of range' error when no TTL answer is given Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves #836 * fixup! nsupdate: fix 'index out of range' error when no TTL answer is given (cherry picked from commit 208df2c) Co-authored-by: Silke Hofstra <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Sep 11, 2023
…nge' error when no TTL answer is given (#7236) nsupdate: fix 'index out of range' error when no TTL answer is given (#7219) * nsupdate: fix 'index out of range' error when no TTL answer is given Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves #836 * fixup! nsupdate: fix 'index out of range' error when no TTL answer is given (cherry picked from commit 208df2c) Co-authored-by: Silke Hofstra <[email protected]>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
…nsible-collections#7219) * nsupdate: fix 'index out of range' error when no TTL answer is given Fix a possible `list index out of range` when no answer is returned in the `ttl_changed` method by applying the existing workaround for NS records to all record types. Resolves ansible-collections#836 * fixup! nsupdate: fix 'index out of range' error when no TTL answer is given
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix a possible
list index out of rangewhen no answer is returned in thettl_changedmethod by applying the existing workaround for NS records to all record types.Resolves #836
ISSUE TYPE
COMPONENT NAME
nsupdate
ADDITIONAL INFORMATION
See #836