Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2] mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives (#147) #149

Merged

Conversation

Andersson007
Copy link
Collaborator

(cherry picked from commit 853db5a)

SUMMARY

Backport of #147

…f Is_Slave and Is_Master return values, add alternatives (ansible-collections#147)

* mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives

* Add changelog fragment

(cherry picked from commit 853db5a)
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (stable-2@5fbac22). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable-2     #149   +/-   ##
===========================================
  Coverage            ?   77.18%           
===========================================
  Files               ?       20           
  Lines               ?     1788           
  Branches            ?      436           
===========================================
  Hits                ?     1380           
  Misses              ?      265           
  Partials            ?      143           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fbac22...144cdde. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

cc @Jorge-Rodriguez @bmalynovytch
No need to review, just an example of the first backport to stable-2 which we should do for our and others' PRs we merge (except breaking changes, they will stay in main only).

There can be also cases, when a somebody else's PR contains both breaking and not breaking changes. In this case it would be
better to ask authors to split such PRs, otherwise we will have to extract non-breaking changes manually and backport which is not good:)

I'll write a short backport_guide.rst

If any questions, feel free to ask.

@Andersson007
Copy link
Collaborator Author

and yesterday i forgot to create stable-1 - created now. We should backport only bugfixes to stable-1.

I will try to use the backport bot to simplify the process.

@Andersson007 Andersson007 merged commit da7e73e into ansible-collections:stable-2 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant