[PR #368/07a72865 backport][stable-2] mysql_role: fix and simplify role member detection #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* mysql_role: fix and simplify role membership detection * add changelog fragment * Update changelogs/fragments/368-mysql_role-fix-member-detection.yml Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Felix Hamme <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 07a7286)
Codecov Report
@@ Coverage Diff @@
## stable-2 #371 +/- ##
============================================
- Coverage 75.80% 75.55% -0.25%
============================================
Files 26 26
Lines 2294 2283 -11
Branches 557 552 -5
============================================
- Hits 1739 1725 -14
- Misses 380 384 +4
+ Partials 175 174 -1
Continue to review full report at Codecov.
|
Andersson007
deleted the
patchback/backports/stable-2/07a72865f7ef67017e1acb3d0bf898f8273bcec0/pr-368
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #368 as merged into main (07a7286).
bugfix for mysql_role
fixes #366 ("detaching too few members")
Instead of parsing the
show grantsstatement output for each user, query the built-in tables to find out who is member of a role.MySQL: mysql.role_edges
MariaDB: mysql.roles_mapping