Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters failing even on empty commit #874

Closed
yurnov opened this issue Feb 3, 2025 · 0 comments · Fixed by #873
Closed

Linters failing even on empty commit #874

yurnov opened this issue Feb 3, 2025 · 0 comments · Fixed by #873

Comments

@yurnov
Copy link
Contributor

yurnov commented Feb 3, 2025

SUMMARY

Linters failing with PR even on empty commit

ISSUE TYPE
  • Bug Report
COMPONENT NAME
  • ci
  • plugins/connection/kubectl.py
ANSIBLE VERSION

N/A

COLLECTION VERSION

Current main branch, most probably stable-3 and stable-5

CONFIGURATION

N/A

OS / ENVIRONMENT

GitHub Action workers

STEPS TO REPRODUCE

Empty commit 259261b pushed that triggered CI

EXPECTED RESULTS

All tests completed sucesfully

ACTUAL RESULTS

Linters failed: https://github.com/ansible-collections/kubernetes.core/actions/runs/13110109779/job/36571972999?pr=873

WARNING  Found incompatible custom yamllint configuration (.yamllint), please either remove the file or edit it to comply with:
  - comments.min-spaces-from-content must be 1
  - comments-indentation must be false
  - octal-values.forbid-implicit-octal must be true
  - octal-values.forbid-explicit-octal must be true.

Read https://ansible.readthedocs.io/projects/lint/rules/yaml/ for more details regarding why we have these requirements. Fix mode will not be available.
WARNING  Listing 2 violation(s) marked as ignored, likely already known
WARNING  Listing 1 violation(s) that are fatal
Error: Variables names must not be Ansible reserved names. (namespace)
Warning: Commands should not change things if nothing needs doing.
Warning: Commands should not change things if nothing needs doing.
Read documentation for instructions on how to ignore specific rule violations.

# Rule Violation Summary

  1 var-naming profile:basic tags:idiom

Failed: 1 failure(s), 2 warning(s) on 143 files. Profile 'production' was required, but 'min' profile passed.
no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored
plugins/connection/kubectl.py:184 Task/Handler: Run a command in My App pod

no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored
plugins/connection/kubectl.py:184 Task/Handler: Run a command in a pod

var-naming[no-reserved]: Variables names must not be Ansible reserved names. (namespace)
plugins/connection/kubectl.py:46

Command failed: got '2', expected '0'
Error: Process completed with exit code 1.
yurnov added a commit to yurnov/kubernetes.core that referenced this issue Feb 3, 2025
yurnov added a commit to willthames/kubernetes.core that referenced this issue Feb 3, 2025
patchback bot pushed a commit that referenced this issue Feb 6, 2025
SUMMARY
It seems that recent updates in linters break CI. Closes #874
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
CI
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Yuriy Novostavskiy
(cherry picked from commit 91df2f1)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Feb 6, 2025
This is a backport of PR #873 as merged into main (91df2f1).
SUMMARY
It seems that recent updates in linters break CI. Closes #874
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
CI
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
yurnov added a commit to yurnov/kubernetes.core that referenced this issue Feb 6, 2025
SUMMARY
It seems that recent updates in linters break CI. Closes ansible-collections#874
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
CI
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Yuriy Novostavskiy
gravesm pushed a commit to gravesm/kubernetes.core that referenced this issue Feb 6, 2025
SUMMARY
It seems that recent updates in linters break CI. Closes ansible-collections#874
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
CI
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Yuriy Novostavskiy
(cherry picked from commit 91df2f1)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Feb 6, 2025
SUMMARY
It seems that recent updates in linters break CI. Closes #874 ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
CI
ADDITIONAL INFORMATION
It's cherry-pick #873 to stable-3 as patch bot failed
Reviewed-by: Mike Graves [email protected]
Reviewed-by: Yuriy Novostavskiy

Reviewed-by: Mike Graves <[email protected]>
abikouo pushed a commit to abikouo/kubernetes.core that referenced this issue Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant