Fix waiting on StatefulSet scale down #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
recheck |
goneri
approved these changes
Mar 7, 2022
|
regate |
|
Pull request merge failed: Pull Request is not mergeable |
When scaling a StatefulSet down to 0 replicas the wait will fail because some properties of the status (readyReplicas, updatedReplicas) will not exist. These are probably defined as omitempty in the API and since the value is zero are not present in the response.
gravesm
force-pushed
the
fix-statefulset-wait
branch
from
1392d62 to
d1eee2e
Compare
gravesm
added a commit
to gravesm/kubernetes.core
that referenced
this pull request
Jun 8, 2022
The ports commit d68dec3 to the refactored code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When scaling a StatefulSet down to 0 replicas the wait will fail
because some properties of the status (readyReplicas, updatedReplicas)
will not exist. These are probably defined as omitempty in the API and
since the value is zero are not present in the response.
Fixes #203
ISSUE TYPE
COMPONENT NAME
k8s_scale
ADDITIONAL INFORMATION