Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoNotMerge] rebase 802: add reset_then_reuse_values support to helm module #861

Closed
wants to merge 4 commits into from
Closed

[DoNotMerge] rebase 802: add reset_then_reuse_values support to helm module #861

wants to merge 4 commits into from

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Jan 18, 2025

SUMMARY

This rebase of #802 for testing purpose

ISSUE TYPE
  • Feature Pull Request

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5db5497fd9b5409282e83042aff456e3

✔️ ansible-galaxy-importer SUCCESS in 4m 59s
✔️ build-ansible-collection SUCCESS in 5m 27s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b57f37385db4e52aad111f31b32535b

✔️ ansible-galaxy-importer SUCCESS in 5m 30s
✔️ build-ansible-collection SUCCESS in 5m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/788e56c661b44da8a1bb987937c81ba2

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 5m 30s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c6d9016da2464a979301d6672fb08e63

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 5m 20s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cd5b45316f924a0293bb186db9ff76fd

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a3bc62cf110f488297e2deaba367b189

✔️ ansible-galaxy-importer SUCCESS in 3m 34s
✔️ build-ansible-collection SUCCESS in 5m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1e04133bda7a4061824a9dae2d659d77

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 5m 16s

@yurnov yurnov force-pushed the rebase-802 branch 4 times, most recently from f977fd3 to 1ad31dd Compare January 18, 2025 22:22
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0a09e4afaa454d5a85823058b4927f76

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 5m 41s

@yurnov
Fix and update Integration test for --reset-then-reuse-values
dec0941 
within this commit helm and helm diff plugin updated to versions that
suppots --reset-then-reuse-values, fixed a few small CI fault and added
tests for older version to ensure warning message. Race condition fixed
by using separate namespace.

--reset-then-reuse-values flag to 'helm upgrade' supported starting from 3.14.0

ref: https://github.com/helm/helm/releases/tag/v3.14.0, helm/helm@a9d59f9
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4fcd4ee5c47f4d68990d00cf09ae9531

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d4a791f7759247bb8d0ebb45fc75ebc1

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 5m 35s

@yurnov
Copy link
Contributor Author

yurnov commented Jan 18, 2025

Closed in favor of #802

@yurnov yurnov closed this Jan 18, 2025
@yurnov yurnov reopened this Jan 19, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c6dbfaa9b97d4179965a92e400779a38

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 5m 35s

@yurnov
refactor module fail for helm_diff_version<3.9.12, helm_version<3.14.0
e43b309 
the main idea to check both versions and print both version in single run

before this commit a failed two requrement will cause only single version in error message
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fe7484fdca4340f29208a31ae0c24513

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 23s

@yurnov yurnov changed the title [WIP] rebase 802: add reset_then_reuse_values support to helm module [DoNotMerge] rebase 802: add reset_then_reuse_values support to helm module Jan 19, 2025
@yurnov yurnov closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurnov @b0z02003