Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation should state what tests are run #2182

Open
kbreit opened this issue Dec 31, 2019 · 2 comments
Open

Documentation should state what tests are run #2182

kbreit opened this issue Dec 31, 2019 · 2 comments

Comments

@kbreit
Copy link
Contributor

kbreit commented Dec 31, 2019

Feature Request

I am importing modules via collections and the linting is giving me errors. However, ansible-test sanity is not showing these errors and I cannot find what command to run to discover these errors before I upload. Galaxy should offer some documentation to show what tests are run so I can reproduce the errors locally.

@samccann
Copy link
Contributor

samccann commented Jan 7, 2020

@kbreit - can you elaborate on the steps you were taking? We chatted a bit in the Ansible Documentation WG meeting today (ansible/community#389 (comment)) but need some more detail on whether this is something just a developer would need, or something a collection user would also need etc.

@kbreit
Copy link
Contributor Author

kbreit commented Jan 7, 2020

@samccann In reverse, this is something a developer would need and not likely a user. I've been running sanity tests using ansible-test sanity --docker default --python 3.7 and it will provide suggestions. However, even when I've fixed all the suggestions/errors, I will receive other problems within Ansible Galaxy when I upload the collection. For example, I don't believe these show up in the ansible-test results.

flake8 Warnings: 
plugins/modules/meraki_intrusion_prevention.py:186:1: F401 'os' imported but unused 
plugins/modules/meraki_intrusion_prevention.py:187:1: F401 'ansible.module_utils.basic.env_fallback' imported but unused 
plugins/modules/meraki_intrusion_prevention.py:188:1: F401 'ansible.module_utils.urls.fetch_url' imported but unused 
plugins/modules/meraki_intrusion_prevention.py:189:1: F401 'ansible.module_utils._text.to_native' imported but unused 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants