Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible.cfg presence in root might break installation from repository #280

Closed
EamonTracey opened this issue Jul 27, 2023 · 3 comments · Fixed by #284
Closed

ansible.cfg presence in root might break installation from repository #280

EamonTracey opened this issue Jul 27, 2023 · 3 comments · Fixed by #284
Labels
bug Something isn't working new

Comments

@EamonTracey
Copy link

EamonTracey commented Jul 27, 2023

Collections do not ship with an ansible.cfg but this repository has one in the root directory. Therefore, if someone builds/installs the collection from the repository using commands like:

git clone https://github.com/ansible/automation_hub_collection
cd automation_hub_collection
ansible-galaxy collection build -vvv
ansible-galaxy install ansible-automation_hub*.tar.gz

then the ansible.cfg in the repository will override other settings.

It looks like the ansible.cfg is used for some tests, so it might be better to keep it elsewhere in the repository, not in the root directory.

@EamonTracey EamonTracey added bug Something isn't working new labels Jul 27, 2023
@sean-m-sullivan
Copy link
Contributor

Generally they can't do that because we variablized the galaxy.yml, which helps with the multiple namespaces as well. I'd be interested in other peoples views on this, as we did use to keep it in the .github folder and copy it to main as part of our workflow.

@Tompage1994
Copy link
Contributor

Personally, I don't like it being in the main for this or for the other collections as it can (and does in the case of controller_configuration) break my (and presumably others') dev workflows. I also think we should revisit the galaxy.yml being in the collection because it would be good if you could install firstly from the repo. As part of the release process we could make it so that the galaxy.yml that is created get updated in the repo. Potentially we append -dev to the version number so it differs from the released version?

Regarding the ansible.cfg I definitely think we should move it out though

@sean-m-sullivan
Copy link
Contributor

I like this change, we keep templating it, but have a persistent copy, best of methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants