Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Install --force still does not overwrite previous installs #266

Closed
ironfroggy opened this issue May 21, 2019 · 1 comment
Closed

Install --force still does not overwrite previous installs #266

ironfroggy opened this issue May 21, 2019 · 1 comment
Assignees
@alikins
Labels
status/new Triage required type/bug
Milestone
Mazer 1.0.0

Comments

@ironfroggy
Copy link
Contributor

Bug Report

MAZER VERSION

Running from devel

name = mazer
version = 0.5.0
config_file = /home/calvin/.ansible/mazer.yml
uname = Linux, willow-epsilon, 4.4.0-17134-Microsoft, #706-Microsoft Mon Apr 01 18:13:00 PST 2019, x86_64
executable_location = /mnt/c/Users/calvin/redhat/.virtualenvs/orion/bin/mazer
python_version = 3.7.1 (default, Oct 22 2018, 11:21:55) [GCC 8.2.0]
python_executable = /mnt/c/Users/calvin/redhat/.virtualenvs/orion/bin/python3.7
CONFIGURATION

defaults

SUMMARY

Installing with --force still bails if a previous install exists and does not force an overwrite. Adding --ignore-errors does not help, either.

STEPS TO REPRODUCE
  • Install version 1.0.0 of a given collection
  • Install version 2.0.0 of a given collection, with the --force flag passed to Mazer
EXPECTED RESULTS

The existing collection should be replaced

ACTUAL RESULTS

The same WARNING as without force, and the given forced version is not installed
@ironfroggy ironfroggy added type/bug status/new Triage required labels May 21, 2019
@ironfroggy ironfroggy added this to the Mazer 1.0.0 milestone May 21, 2019
@ironfroggy
Copy link
Contributor Author

IMHO, it would be just as valid to remove the flag as to fix it. Its not strictly a necessary flag. You can always remove and then install a new version, instead. I would advocate for whichever is faster. The main issue now is a documented flag does not behave as documented.

@alikins alikins self-assigned this May 30, 2019
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
WIP Rm already installed if --force is used
740db5e 
TODO: do already_installed check with open ended version spec

Fixes ansible#266
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
WIP - let already_installed check be vague
8b4ef92 
This lets 'install --force' force install
older or newer versions of a collection.

Fixes ansible#266
@alikins alikins mentioned this issue May 30, 2019
Merged
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
WIP Rm already installed if --force is used
0798e27 
TODO: do already_installed check with open ended version spec

Fixes ansible#266
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
WIP - let already_installed check be vague
88da5db 
This lets 'install --force' force install
older or newer versions of a collection.

Fixes ansible#266
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Make 'install --force' work (Fixes ansible#266)
1885da0 
When checking if a collection intended
to be installed is already installed, let
the check of the installed packages be more
vague. ie, just check if there is a collection
by that namespace/name already installed.

If a collection is installed, and --force is
used, then make sure the already installed
collection is removed, then the new collection
is installed.

This lets 'install --force' force install
older or newer versions of a collection.

Fixes ansible#266
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alikins alikins

Labels
status/new Triage required type/bug
Projects
None yet
Milestone
Mazer 1.0.0
Development

No branches or pull requests
2 participants
@alikins @ironfroggy