Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Review logging and default logging config (make sure default level is INFO) #267

Closed
alikins opened this issue May 21, 2019 · 0 comments · Fixed by #273
Closed

Review logging and default logging config (make sure default level is INFO) #267

alikins opened this issue May 21, 2019 · 0 comments · Fixed by #273
Assignees
@alikins
Labels
priority/medium status/in-progress type/bug
Milestone
Mazer 1.0.0

Comments

@alikins
Copy link
Contributor

alikins commented May 21, 2019

Bug Report

Review logging and default logging config (make sure default level is INFO)
before 1.0.0.

Cleanup debug logging, etc.
@alikins alikins added this to the Mazer 1.0.0 milestone May 21, 2019
@alikins alikins self-assigned this May 21, 2019
@alikins alikins added status/in-progress and removed status/new Triage required labels May 30, 2019
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Set default logging level to INFO
7a57475 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
By default, only log http info to mazer-http.log
cb689b6 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Move impl of mazer version from actions->mazer_version
d44748a 
Move the impl details of collecting the mazer version info
for `mazer version` to ansible_galaxy.mazer_version so that
other modules can use it (namely, ansible_galaxy.cli.galaxy
for logging info at cli startup)

Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
On cli startup, log a info line with basic info
b387373 
And 'info' level log the exit code.

For ex:

[2019-05-30 11:17:51,249 28223 I] ansible_galaxy_cli.cli.galaxy run:236 - \
  exe="/home/adrian/venvs/mazer040test/bin/mazer" version=0.5.0 \
  config_file="/home/adrian/.ansible/mazer.yml" \
  collections_path="/home/adrian/.ansible/collections" \
  server=http://localhost:8000 action=install

Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Log GalaxyErrors exc info that make it to main at debug
895da01 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Only log display_callback msgs at DEBUG level
8e3413f 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Better format for info log msgs for installs
c4e5fc2 
Fixes ansible#267
@alikins alikins mentioned this issue May 30, 2019
Merged
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Let log handler set basename rel to MAZER_HOME
25e241c 
So a logging config (the default logging config in particular)
can provide a 'basename' arg for
ExpandTildeWatchedFileHandler that will be used relative to
MAZER_HOME.

So:
    $ mkdir /tmp/mazer_home
    $ MAZER_HOME=/tmp/mazer_home mazer install testing.foo

Will use any config in /tmp/mazer_home/, plus by default install
collections to MAZER_HOME/collections, will also now log by
default to MAZER_HOME/mazer.log and MAZER_HOME/mazer-http.log

Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Set default logging level to INFO
c32a6ae 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
By default, only log http info to mazer-http.log
4dd2fce 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Move impl of mazer version from actions->mazer_version
b3daad3 
Move the impl details of collecting the mazer version info
for `mazer version` to ansible_galaxy.mazer_version so that
other modules can use it (namely, ansible_galaxy.cli.galaxy
for logging info at cli startup)

Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
On cli startup, log a info line with basic info
184a705 
And 'info' level log the exit code.

For ex:

[2019-05-30 11:17:51,249 28223 I] ansible_galaxy_cli.cli.galaxy run:236 - \
  exe="/home/adrian/venvs/mazer040test/bin/mazer" version=0.5.0 \
  config_file="/home/adrian/.ansible/mazer.yml" \
  collections_path="/home/adrian/.ansible/collections" \
  server=http://localhost:8000 action=install

Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Log GalaxyErrors exc info that make it to main at debug
b19a2d3 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Only log display_callback msgs at DEBUG level
a2c4346 
Fixes ansible#267
alikins added a commit to alikins/mazer that referenced this issue May 30, 2019
@alikins
Better format for info log msgs for installs
b7837ea 
Fixes ansible#267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Let log handler set basename rel to MAZER_HOME
b42afb6 
So a logging config (the default logging config in particular)
can provide a 'basename' arg for
ExpandTildeWatchedFileHandler that will be used relative to
MAZER_HOME.

So:
    $ mkdir /tmp/mazer_home
    $ MAZER_HOME=/tmp/mazer_home mazer install testing.foo

Will use any config in /tmp/mazer_home/, plus by default install
collections to MAZER_HOME/collections, will also now log by
default to MAZER_HOME/mazer.log and MAZER_HOME/mazer-http.log

Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Set default logging level to INFO
a249727 
Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
By default, only log http info to mazer-http.log
0631da4 
Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Move impl of mazer version from actions->mazer_version
f90efed 
Move the impl details of collecting the mazer version info
for `mazer version` to ansible_galaxy.mazer_version so that
other modules can use it (namely, ansible_galaxy.cli.galaxy
for logging info at cli startup)

Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
On cli startup, log a info line with basic info
912f240 
And 'info' level log the exit code.

For ex:

[2019-05-30 11:17:51,249 28223 I] ansible_galaxy_cli.cli.galaxy run:236 - \
  exe="/home/adrian/venvs/mazer040test/bin/mazer" version=0.5.0 \
  config_file="/home/adrian/.ansible/mazer.yml" \
  collections_path="/home/adrian/.ansible/collections" \
  server=http://localhost:8000 action=install

Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Log GalaxyErrors exc info that make it to main at debug
33d0e84 
Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Only log display_callback msgs at DEBUG level
6faea7f 
Fixes #267
alikins added a commit that referenced this issue May 30, 2019
@alikins
Better format for info log msgs for installs
f1c5af5 
Fixes #267
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alikins alikins

Labels
priority/medium status/in-progress type/bug
Projects
None yet
Milestone
Mazer 1.0.0
Development

Successfully merging a pull request may close this issue.

Tweaks for default log level (Fixes #267) alikins/mazer
1 participant
@alikins