This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Scm url reqspec 236 #241
Merged
Scm url reqspec 236 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collections artifacts don't have a top dir, so --prefix $name doesn't work with collections installed from a git scm url Ditto for 'hg', but use `--prefix .` to avoid a top dir.
Previously it was 'req_spec_string' to distinquish from RepositorySpec, but RepoSpec and ReqSpec are separated now, so just use 'spec_string' for both as that is what the repo spec parsing code does. Add 'scm' attribute back to RequirementSpec. Fixes part of ansible#236 Fixes "AttributeError: 'RequirementSpec' object has no attribute 'scm'" error on 'mazer install git+https://github.com/alikins/whatever' (collection install still fails, but for a different reason)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix some issues with using scm url with collections from the cli.
later build the right url for archive since the
git+https://github.com/alikins/whateverstyle isnt understood by git, git-archive, or the scm_archive module
Fixes part of the issue reported in #236 for now.
Long term, may just remove scm_url support entirely, or at least not support it except for
semver version tags.
Related: #236
ISSUE TYPE
MAZER VERSION
ADDITIONAL INFORMATION