Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover remains visible when component tree is suspended #38158

Open
insertmike opened this issue Oct 21, 2022 · 5 comments
Open

Popover remains visible when component tree is suspended #38158

insertmike opened this issue Oct 21, 2022 · 5 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@insertmike
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Open Popover by clicking on the Open Popover button
  2. Trigger suspense by clicking on the popover content button Hide and load data
  3. See popover remaining visible while the component tree is suspended.

What is expected?

The popover to be hidden.

What is actually happening?

The popover remains visible.

Environment Info
antd 4.23.6
React 17
System Linux
Browser Google Chrome

React.Suspense provide a lifecycle so components can handle the display:none removal. This can be used to handle this: facebook/react#14536

@insertmike insertmike changed the title Popover does not get hidden when component suspend via React Suspense Popover remains visible when component tree is suspended Oct 21, 2022
@insertmike
Copy link
Author

For the people facing this issue, you can use setTimeout to delay the suspense triggering action with 100 or 200ms in order for the popover to hide before react triggers the suspense api.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Oct 23, 2022
@github-actions
Copy link
Contributor

Hello @insertmike. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @insertmike,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@jazimabbas
Copy link

Please assign this task to me .. If this is not assigned to anyone .. Thanks in advance ..

@afc163
Copy link
Member

afc163 commented Nov 1, 2022

PR is welcome @Jazim-Abbas

@moussa32
Copy link

I am facing the same problem as you but I am using react-query while enable suspanse in useQuery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

4 participants