Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile with clang-16 #194

Merged
merged 2 commits into from
Jun 22, 2023
Merged

compile with clang-16 #194

merged 2 commits into from
Jun 22, 2023

Conversation

mikelik
Copy link
Contributor

@mikelik mikelik commented Jun 16, 2023 •
edited
Loading

Change Description

Relates to #192
Allows to compile CDT with clang-16.
I have added new Docker image with ubuntu22 & clang-16.
This is also related to #185

Changes:

  1. get_types seems to be unused
  2. parameters_from_impl is used (indirectly) by return_type_t - tests for it are in traits_tests.cpp.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@mikelik mikelik self-assigned this Jun 16, 2023
@mikelik mikelik force-pushed the mikelik/clang-fix branch 6 times, most recently from 22df06e to 2cc9a6e Compare June 16, 2023 13:50
@mikelik mikelik force-pushed the mikelik/clang-fix branch from 2cc9a6e to 7b058b4 Compare June 16, 2023 14:11
@mikelik mikelik changed the title WIP - Draft - compile with clang-16 compile with clang-16 Jun 16, 2023
@mikelik mikelik marked this pull request as ready for review June 16, 2023 14:27
@mikelik mikelik requested review from dimas1185 and larryk85 June 16, 2023 14:27
@mikelik mikelik requested a review from ScottBailey June 21, 2023 14:46
@mikelik mikelik merged commit 2838fe7 into main Jun 22, 2023
@mikelik mikelik deleted the mikelik/clang-fix branch June 22, 2023 02:07
@spoonincode spoonincode mentioned this pull request Sep 26, 2023
Merged
@ericpassmore
Copy link
Contributor

ericpassmore commented May 6, 2024 •
edited
Loading

Note:start
group: FEATURE
category: INTERNALS
summary: Compile with clang-16, adding support for datatypes uint128, uint256, and efficient to and from hex operations.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottBailey ScottBailey ScottBailey approved these changes

@heifner heifner heifner approved these changes

@dimas1185 dimas1185 dimas1185 approved these changes

@larryk85 larryk85 Awaiting requested review from larryk85

Assignees

@mikelik mikelik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikelik @ericpassmore @ScottBailey @heifner @dimas1185