Use spring instead of leap for integration tests #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
approved these changes
May 2, 2024
linh2931
approved these changes
May 2, 2024
| @@ -18,7 +18,7 @@ using namespace eosio::testing; | |||
|
|
|||
| BOOST_AUTO_TEST_SUITE(multi_index_tests) | |||
|
|
|||
| // this test is copy from leap test_api_multi_index | |||
| // this test is copy from spring test_api_multi_index | |||
There was a problem hiding this comment.
The s in this spring should be capitalized as Spring.
There was a problem hiding this comment.
Here Spring is used as a name (Areg told me once when I updated some other files).
| @@ -1,10 +1,10 @@ | |||
| cmake_minimum_required( VERSION 3.5 ) | |||
|
|
|||
| set(EOSIO_VERSION_MIN "3.1") | |||
| set(EOSIO_VERSION_MIN "1.0") | |||
There was a problem hiding this comment.
Should it still be called EOSIO_VERSION, now that it goes back to 1.0. But no need to change for now.
greg7mdp
approved these changes
May 2, 2024
| @@ -18,7 +18,7 @@ using namespace eosio::testing; | |||
|
|
|||
| BOOST_AUTO_TEST_SUITE(multi_index_tests) | |||
|
|
|||
| // this test is copy from leap test_api_multi_index | |||
| // this test is copy from spring test_api_multi_index | |||
There was a problem hiding this comment.
Suggested change
| // this test is copy from spring test_api_multi_index | |
| // this test is copied from spring's test_api_multi_index |
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
API Changes
Documentation Additions
Resolves #276