Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base64 encoding #1482

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix base64 encoding #1482

merged 2 commits into from
Aug 10, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 8, 2023

Remove the invalid addition of "=" to all base64 encoded strings from fc::variant.
Also update base64 implementation from: https://github.com/ReneNyffenegger/cpp-base64

Resolves #1461

@heifner heifner requested review from linh2931 and greg7mdp August 8, 2023 16:20
Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we ruled out boost's base64 impl, but can we use openssl's base64 instead of having our own impl?

@heifner
Copy link
Member Author

heifner commented Aug 8, 2023

I know we ruled out boost's base64 impl, but can we use openssl's base64 instead of having our own impl?

Doesn't seem to provide base64url_decode url decoding used by webauthn.

Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared with the upstream version. It looked good. Approve the PR if we decide use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Base64 padding returned by APIs
4 participants