Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] PH: Reliability improvements #1852

Merged
merged 12 commits into from
Nov 2, 2023
Merged

[5.0 -> main] PH: Reliability improvements #1852

merged 12 commits into from
Nov 2, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 2, 2023

  • Performance harness tests were failing because the last few trxs from the trx_generator were being dropped. Modified the trx_generator to wait for all writes to finish before terminating.
  • Modify the performance harness to wait for the complete test time for the trxs in blocks.
  • Update the performance harness to --print-missing-transactions by default as this is very useful for debugging why the test failed.
  • Updated Cluster.py to support --produce-block-offset-ms 0 for older versions of nodeos.

Still need to run a complete test run on a quiescent machine.

Merges release/5.0 into main including #1814

Issue #1690

heifner added 12 commits October 24, 2023 11:52
@heifner
GH-1690 Socket should only be accessed from thread-pool thread. Use a…
db98dbc 
…sync_write instead of send. Wait for all write callbacks to finish before exit.
@heifner
GH-1690 Need to wait over time of run, so offset from startBlock. Mak…
82e2146 
…e --print-missing-transactions=True the default as it is useful when there are missing trxs.
@heifner
GH-1690 Changed waitForTransactionsInBlockRange to use a start/end in…
339f542 
…stead of start/offset. Pass in the start of empty blocks as the end of the range.
@heifner
GH-1690 Add backwards compatibility for --produce-block-offset-ms 0…
bfe2a4c 
… for performance harness
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-1690-perf-5.0
c59625d
@heifner
GH-1690 Not allowed to write to socket until previous write completes.
b79d98d
@heifner
Merge branch 'release/5.0' into GH-1690-perf-5.0
35372f6
@heifner
GH-1690 Report values used in comparison
bed5a26
@heifner
GH-1690 Remove unneeded include
db817f7
@heifner
GH-1690 Add better description
b0f567d
@heifner
Merge pull request #1814 from AntelopeIO/GH-1690-perf-5.0
dafd740 
[5.0] PH: Reliability improvements
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-1690-perf-main
06965dd
@heifner heifner requested review from greg7mdp and linh2931 November 2, 2023 16:13
@heifner heifner added the OCI Work exclusive to OCI team label Nov 2, 2023
@heifner heifner merged commit c092011 into main Nov 2, 2023
@heifner heifner deleted the GH-1690-perf-main branch November 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @greg7mdp @linh2931