only run libtester tests on ubuntu22 #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By far the primary purpose of the libtester tests are to ensure we didn't goof proper referencing or installation of a libtester dependency since they aren't handled automatically. It's easy to break in one of the three ways we support.
Testing libtester on all the supported Ubuntu versions is a distant second purpose. But I am not sure I can think of cases where this has gone awry recently, and there is nothing in libtester's cmake complexity that is different for different Linux distros.
Due to #1936 let's just remove libtester testing on ubuntu20 for now. While I'm sure it's possible (even easy) to fix the underlying issue of needing to use a newer compiler for these tests on ubuntu20, it's nice not to add more complexity for this case imo. Resolves #1936 indirectly.