Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] only register prometheus handlers when prometheus_plugin enabled; fixing memory leak #2039

Merged
merged 5 commits into from
Jan 4, 2024
Merged

[5.0 -> main] only register prometheus handlers when prometheus_plugin enabled; fixing memory leak #2039

merged 5 commits into from
Jan 4, 2024

Conversation

spoonincode
Copy link
Member

main merge of #2038 to fix leak when prometheus not enabled; resolves #2030

@spoonincode spoonincode merged commit 8182092 into main Jan 4, 2024
26 checks passed
@spoonincode spoonincode deleted the prom_handler_fix branch January 4, 2024 19:43
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Fix memory leak by moving initialization of http handler associated with app plugins. Prevents creation http requests that never get drained. This issue was only in leap v5-rc releases, never surfaced in a stable release.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate recent surge in growth rate of system RAM usage
4 participants
@spoonincode @ericpassmore @heifner @linh2931