add CI "platform" running UBSAN #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Mar 12, 2024
| zlib1g-dev \ | ||
| zstd | ||
|
|
||
| RUN yes | bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" llvm.sh 18 |
There was a problem hiding this comment.
Use the latest clang for these builds; presumably it has the best & most reliable UBSAN yet.
spoonincode
commented
Mar 12, 2024
| COPY <<-EOF /ubsan.supp | ||
| vptr:wasm_eosio_validation.hpp | ||
| vptr:wasm_eosio_injection.hpp | ||
| EOF |
There was a problem hiding this comment.
EOS VM's WASM parser seems to do a number of invalid casts, I believe casting between something<Foo> and something<Bar> when something<T> is not derived from any sort of base class. Resolving this might not be straightforward; and it's not clear if we may replace EOS VM in the mid/long term; so suppress these errors for now.
greg7mdp
approved these changes
Mar 12, 2024
heifner
approved these changes
Mar 12, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there are still a few remaining violations (see comments below), I think we're in a good spot to enable UBSAN in CI builds. UBSAN is expected to generate no false positives so requiring it to pass is reasonable.
An example run with failures is here,
https://github.com/AntelopeIO/leap/actions/runs/8252261490