Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kv_database_config from snapshots starting in Spring 1.0 (snapshot V7) #109

Merged
merged 5 commits into from
May 6, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented May 3, 2024

kv_database_config has been stored in snapshot's global_property_object since V4 but it has never been used.

  • Spring 1.0 and future releases stop storing it in snapshot.
  • Snapshots V4/V5/V6 still keep it for backward compatibilities.
  • kv_config.hpp has been updated to warn against future uses.

Resolves #102

@linh2931 linh2931 requested review from greg7mdp and heifner May 3, 2024 19:32
* Current uses of kv_database_config were removed in Spring 1.0.
* Do not use it in the future.
* The file is kept for backward compatibilities as it was used in snapshots
* containing snapshot_global_property_object_v4 and snapshot_global_property_object_v4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comment

@linh2931 linh2931 merged commit d411eea into main May 6, 2024
36 checks passed
@linh2931 linh2931 deleted the rm_kv_db_config_from_snapshots branch May 6, 2024 00:17
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Remove unused key value database config starting from v7 snapshots.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove kv_database_config from snapshot_global_property_object
4 participants