Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid assertion for action_mroot #176

Merged
merged 2 commits into from
May 21, 2024
Merged

Remove invalid assertion for action_mroot #176

merged 2 commits into from
May 21, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 21, 2024 •
edited
Loading

  • action_mroot can be empty if onblock fails
  • Add test for a failing onblock

Resolves #168

@heifner heifner requested review from linh2931 and spoonincode May 21, 2024 14:29
@heifner heifner added the OCI Work exclusive to OCI team label May 21, 2024
@heifner heifner merged commit fd8bba7 into main May 21, 2024
36 checks passed
@heifner heifner deleted the GH-168-assert-action_mroot branch May 21, 2024 17:27
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Remove unneeded check, as it was causing test failures for legitimate empty block scenarios.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assert(!action_mroot.empty()) in valid_t block_state::new_valid() should not be needed
4 participants
@heifner @ericpassmore @spoonincode @linh2931