Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protocol_feature_tests to run in both legacy and savanna #177

Merged
merged 1 commit into from
May 21, 2024
Merged

Update protocol_feature_tests to run in both legacy and savanna #177

merged 1 commit into from
May 21, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 21, 2024

Part of #11

@heifner heifner linked an issue May 21, 2024 that may be closed by this pull request
Create IF versions of applicable unittests #11
Closed
@heifner heifner requested review from linh2931 and spoonincode May 21, 2024 14:35
@heifner heifner added the OCI Work exclusive to OCI team label May 21, 2024
linh2931
linh2931 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only transition to Savanna if setup_policy is full. I think there is no harm to run tests of other setup_policy in both Legacy and Savanna.

@heifner heifner merged commit f986a07 into main May 21, 2024
36 checks passed
@heifner heifner deleted the GH-11-protocol-feature-tests branch May 21, 2024 17:27
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Update protocol features tests to support different consensus modes.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IF versions of applicable unittests
4 participants
@heifner @ericpassmore @spoonincode @linh2931