Rename instant_finality protocol feature to savanna #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t depend on all previous protocol features
greg7mdp
approved these changes
May 28, 2024
linh2931
reviewed
May 28, 2024
| case setup_policy::full_except_do_not_transition_to_savanna: | ||
| case setup_policy::full_except_do_not_disable_deferred_trx: { | ||
| case setup_policy::full_except_do_not_disable_deferred_trx: | ||
| case setup_policy::full_except_do_not_transition_to_savanna: { |
There was a problem hiding this comment.
full_except_do_not_transition_to_savanna is not merged in yet. I don't see where it is defined in your branch.
There was a problem hiding this comment.
I targeted this PR to your PR to avoid conflicts.
|
Note:start |
…nna-protocol-feature
…nna-protocol-feature
linh2931
reviewed
Jun 4, 2024
| @@ -285,7 +283,9 @@ namespace eosio::testing { | |||
| preactivate_all_builtin_protocol_features(); | |||
| } | |||
| produce_block(); | |||
| set_bios_contract(); | |||
| if (policy == setup_policy::full || policy == setup_policy::full_except_do_not_transition_to_savanna ) { | |||
There was a problem hiding this comment.
Maybe add a comment here why bios contract might be needed for setup_policy::full_except_do_not_transition_to_savanna (to transition to Savanna later).
linh2931
approved these changes
Jun 4, 2024
Fix terminate-at-block for transition blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
instant_finalityprotocol feature tosavanna.Make
savannaprotocol feature depend on all previous protocol features.Resolves #170