IF: P2P: Fix stuck in peer syncing state #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure: https://github.com/AntelopeIO/spring/actions/runs/8662797812/job/23755999003
The producing node (Node00) did not send to the validating node (Node02) because Node00 thought Node02 was still syncing from it. Node00 thought that Node02 was still syncing because when Node02 tried to send it the handshake after receiving blocks, it had not applied any of those blocks to its internal block chain state. Therefore, the handshake was not sent because nothing had changed.
Delay sending handshakes on becoming
in_sync
until controller state is caught up to head. This will make sure the handshake sent to other nodes reflects current synced up state instead of non synced up state. Also go fromlib_catchup
tohead_catchup
instead of jumping toin_sync
so that the mechanism for determining to send handshakes does not miss the transition.