Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Increase timeout for votes #270

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Test: Increase timeout for votes #270

merged 2 commits into from
Jun 11, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 11, 2024

Although unlikely, it does seem possible with running so many unittests concurrently that a particular test might not receive necessary CPU for 1 second. Increase timeout to 5 seconds. If this fails again, we can then assume this is something real (a vote is actually getting lost).

Resolves #235

@heifner heifner requested review from linh2931 and greg7mdp June 11, 2024 13:55
@heifner heifner added the OCI Work exclusive to OCI team label Jun 11, 2024
@heifner heifner merged commit 54b57fc into main Jun 11, 2024
36 checks passed
@heifner heifner deleted the GH-235-test branch June 11, 2024 16:03
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: For better test stability increase timeout for tests.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failure: finality_unit_test_eos-vm
4 participants