Move savanna pending lib calculation to forkdb add() #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jul 10, 2024
| return {}; | ||
| const auto& if_ext = std::get<instant_finality_extension>(itr->second); | ||
| return if_ext.qc_claim; | ||
| } |
There was a problem hiding this comment.
We really should have a generic function to extract an extension (like template<typename Ext> Ext extract_extension(), but checking if the extension is present and returning a std::optional).
linh2931
approved these changes
Jul 10, 2024
| auto itr = header_exts.lower_bound(instant_finality_extension::extension_id()); | ||
| if (itr == header_exts.end()) | ||
| return {}; | ||
| const auto& if_ext = std::get<instant_finality_extension>(itr->second); |
There was a problem hiding this comment.
Should we change this long name instant_finality_extension to savanna_extension or something?
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move tracking of Savanna pending LIB into fork database. The fork database is in charge of tracking and persisting cached current pending Savanna LIB.
Resolves #333