Fix a bug in libtester `produce_blocks` and make SHiP unit tests work in both Savanna and Legacy #367

linh2931 · 2024-07-15T15:26:57Z

Make SHiP unit tests run in both Savanna and Legacy:

Fix a bug in libtester produce_blocks() which enables voting when it should not.
Fix test_splitted_log such that it works in Savanna.
Fix test_fork such that it works in Savanna.
Update the rest of SHiP unit tests to work in both Savanna and Legacy.

Resolved #179

…ester

spoonincode

ship test related changes LGTM

ericpassmore · 2024-07-15T17:52:34Z

Note:start
group: STABILITY
category: TEST
summary: Update libtester to work for SHiP in Legacy and Savanna mode.
Note:end

linh2931 added 6 commits July 13, 2024 17:56

Update SHiP delta related tests to work in both Legacy and Savanna modes

e35ba31

Make state_history_tester as a template of legacy_tester or savanna_t…

9f959ee

…ester

Compile with new state_history_testers

cb7adc6

Update test_splitted_log to work in both Savanna and Legacy

423586c

Make all SHiP fork related tests work under Savanna

89eb99d

Improve comments

c199e92

linh2931 requested review from heifner, spoonincode and greg7mdp July 15, 2024 15:27

heifner approved these changes Jul 15, 2024

View reviewed changes

spoonincode approved these changes Jul 15, 2024

View reviewed changes

greg7mdp approved these changes Jul 15, 2024

View reviewed changes

Merge branch 'main' into ship_unit_tests_legacy_savanna_modes

6e29f53

linh2931 merged commit ab28473 into main Jul 15, 2024
36 checks passed

linh2931 deleted the ship_unit_tests_legacy_savanna_modes branch July 15, 2024 20:54

Provide feedback