Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LIB in commit block under normal conditions #408

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Move LIB in commit block under normal conditions #408

merged 3 commits into from
Jul 25, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 25, 2024

Move log_irreversible() before log of Received block. This also simplifies the log_irreversible() call by moving its normal call location inside of commit_block(). Now both produced blocks and validated blocks have log_irreversible() called inside commit_block() when in non-irreversible mode.

Deep-mind output changed because the LIB is advanced now before calling the deep mind ACCEPTED_BLOCK or ACCEPTED_BLOCK_V2 call. This is another nice side-affect as deep-mind will see LIB moving quicker than before.

info  2024-07-25T19:16:05.978 nodeos    controller.cpp:3507           log_applied          ] Received block f15b78dfea9e35e2... #170 @ 2024-07-25T19:16:06.000 signed by defproducerg [trxs: 18, lib: 168, net: 3600, cpu: 6407, elapsed: 2454, time: 8521, latency: -21 ms]
info  2024-07-25T19:16:06.445 nodeos    controller.cpp:3507           log_applied          ] Received block 65fce091b05361dd... #171 @ 2024-07-25T19:16:06.500 signed by defproducerg [trxs: 10, lib: 169, net: 2000, cpu: 3903, elapsed: 2136, time: 7831, latency: -54 ms]
info  2024-07-25T19:16:06.901 nodeos    controller.cpp:3507           log_applied          ] Received block 362fd6059b375244... #172 @ 2024-07-25T19:16:07.000 signed by defproducerg [trxs: 8, lib: 170, net: 1600, cpu: 2987, elapsed: 1136, time: 4321, latency: -98 ms]

Resolves #404

@heifner heifner added the OCI Work exclusive to OCI team label Jul 25, 2024
@heifner heifner requested review from linh2931 and greg7mdp July 25, 2024 20:00
@heifner heifner merged commit f2ba289 into main Jul 25, 2024
71 checks passed
@heifner heifner deleted the GH-404-lib branch July 25, 2024 20:59
@ericpassmore
Copy link
Contributor

Note:start
group: LOGGING
category: INTERNALS
summary: Update logging call to better represent timing of LIB advancement.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logged lib of "Received block" trails by one
4 participants