Move LIB in commit block under normal conditions #408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
log_irreversible()
before log ofReceived block
. This also simplifies thelog_irreversible()
call by moving its normal call location inside ofcommit_block()
. Now both produced blocks and validated blocks havelog_irreversible()
called insidecommit_block()
when in non-irreversible mode.Deep-mind output changed because the LIB is advanced now before calling the deep mind
ACCEPTED_BLOCK
orACCEPTED_BLOCK_V2
call. This is another nice side-affect as deep-mind will see LIB moving quicker than before.Resolves #404