Add more validations on QC's votes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Aug 5, 2024
heifner
reviewed
Aug 6, 2024
heifner
requested changes
Aug 8, 2024
|
Note:start |
heifner
approved these changes
Aug 8, 2024
greg7mdp
approved these changes
Aug 9, 2024
libraries/chain/finality/qc.cpp
Outdated
| pending_vote_index); | ||
| } | ||
|
|
||
| // returns true if ithe other and I vote iin the same way on my_vote_index |
There was a problem hiding this comment.
Suggested change
| // returns true if ithe other and I vote iin the same way on my_vote_index | |
| // returns true iff the other and I voted the same way |
libraries/chain/finality/qc.cpp
Outdated
| for (size_t i=0; i<strong_votes->size(); ++i) { | ||
| // at most one is true | ||
| EOS_ASSERT( !((*strong_votes)[i] && (*weak_votes)[i]), invalid_qc_claim, | ||
| "finalizer (bit index ${i}) votes both strong and weak", |
There was a problem hiding this comment.
Suggested change
| "finalizer (bit index ${i}) votes both strong and weak", | |
| "finalizer (bit index ${i}) voted both strong and weak", |
libraries/chain/finality/qc.cpp
Outdated
Comment on lines
39
to
40
| // We have already verified the same index is not voted on both strong | ||
| // and weak for a given qc_sig_t (I or other). |
There was a problem hiding this comment.
Suggested change
| // We have already verified the same index is not voted on both strong | |
| // and weak for a given qc_sig_t (I or other). | |
| // We have already verified the same index has not voted both strong | |
| // and weak for a given qc_sig_t (I or other). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more validations on QC's votes:
Resolves #467