[1.0] Update chainbase to tip (initialization / move operations update) #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
heifner
approved these changes
Aug 15, 2024
|
This really needs to go to release branch? Does it fix a defect? |
I think it fixes a potential defect (possible `_segment_manager overwrite in move assignment operator), but not a reported issue. PRs #558 and #550 did not fix defects. I think this may be useful for updating boost in 1.0, and Kevin also thought it should go to @arhag which branch would you like me to target this PR to? |
spoonincode
approved these changes
Aug 15, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update chainbase to tip, which includes some fixes for missing member initialization, as well as move operator fixes.
These were found when investigating boost 1.85 ci/cd failures with
assertonbuilds.