Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Do not allow set_finalizers during transition #60

Merged
merged 5 commits into from
Apr 23, 2024
Merged

IF: Do not allow set_finalizers during transition #60

merged 5 commits into from
Apr 23, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 23, 2024

Setting finalizers during transition causes the transition to fail.

@heifner heifner requested review from linh2931 and greg7mdp April 23, 2024 02:23
@heifner heifner added the OCI Work exclusive to OCI team label Apr 23, 2024
linh2931
linh2931 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for this? Or create an issue for tracking test and get this PR in.

@heifner heifner merged commit b03ba95 into savanna Apr 23, 2024
36 checks passed
@heifner heifner deleted the setfinalizer-once branch April 23, 2024 13:44
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Do not allow set_finalizers during transition.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @greg7mdp @linh2931