Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] restore cmake dependency needed for test contract compilation #673

Merged
merged 2 commits into from
Aug 30, 2024
Merged

[1.0] restore cmake dependency needed for test contract compilation #673

merged 2 commits into from
Aug 30, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Aug 30, 2024 •
edited
Loading

removed in dd66bfc

Without this PR we have compilation issues such as:

cFAILED: libraries/testing/CMakeFiles/eosio_testing.dir/contracts.cpp.o 
/usr/bin/clang++-18 -DBN256_HAS_EXTINT 
...
 olor=always -Wno-register -MD -MT libraries/testing/CMakeFiles/eosio_testing.dir/contracts.cpp.o -MF libraries/testing/CMakeFiles/eosio_testing.dir/contracts.cpp.o.d -o libraries/testing/CMakeFiles/eosio_testing.dir/contracts.cpp.o -c /home/greg/github/enf/spring/build_clang18_debug/libraries/testing/contracts.cpp
<inline asm>:6:9: error: Could not find incbin file '/home/greg/github/enf/spring/build_clang18_debug/libraries/testing/contracts/eosio.bios/eosio.bios.wasm'
    6 | .incbin "/home/greg/github/enf/spring/build_clang18_debug/libraries/testing/contracts/eosio.bios/eosio.bios.wasm"
      |         ^
<inline asm>:24:9: error: Could not find incbin file '/home/greg/github/enf/spring/build_clang18_debug/libraries/testing/contracts/eosio.bios/eosio.bios.abi'
   24 | .incbin "/home/greg/github/enf/spring/build_clang18_debug/libraries/testing/contracts/eosio.bios/eosio.bios.abi"
      |         ^

@greg7mdp greg7mdp changed the base branch from main to release/1.0 August 30, 2024 15:06
@heifner heifner self-requested a review August 30, 2024 15:09
@heifner heifner added this to the Spring v1.0.0 milestone Aug 30, 2024
@heifner heifner changed the title restore cmake dependency needed for test contract compilation [1.0] restore cmake dependency needed for test contract compilation Aug 30, 2024
@greg7mdp greg7mdp requested a review from linh2931 August 30, 2024 15:25
@greg7mdp greg7mdp merged commit f8104d4 into release/1.0 Aug 30, 2024
36 checks passed
@greg7mdp greg7mdp deleted the fix_test_contract_compilation_issue branch August 30, 2024 18:31
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Add missing dependency in CMake enabling CI system to build test contracts from source.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spring v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@greg7mdp @ericpassmore @heifner @linh2931