Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Fails to Detect Errors on git push After Switching from @jsdevtools/ez-spawn to tinyexec in v9.9.0 #67

Closed
5 of 7 tasks
Nyaasu66 opened this issue Jan 8, 2025 · 1 comment

Comments

@Nyaasu66
Copy link

Nyaasu66 commented Jan 8, 2025

Describe the bug

Hello,

I have encountered an issue with the recent update of the library to version 9.9.0. In this update, the built-in command execution library was changed from @jsdevtools/ez-spawn to tinyexec. Since this change, I have noticed that when executing git push, the script fails to correctly detect errors and incorrectly assumes that the push operation was successful.

Relevant line of code:

await x('git', ['push'])

Relevant commit:
780b7cc

Reproduction

  1. Execute git reset --hard HEAD^ in a local git repository.
  2. Run pnpx bumpp, and enter 'Y' to continue.
  3. Observe that even when the push should fail, the output incorrectly shows ✔ Git push.
  4. If you run pnpx [email protected], it correctly displays git push exited with a status of 1 ..., indicating the failure as expected.

System Info

System:
    OS: macOS 15.1.1
    CPU: x64 Intel(R) Core(TM)
    Memory: 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.20.3 - ~/.nvm/versions/node/v18.20.3/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v18.20.3/bin/npm
    pnpm: 8.15.8 - ~/Library/pnpm/pnpm

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@antfu antfu closed this as completed in 52816cc Jan 8, 2025
@Nyaasu66
Copy link
Author

Nyaasu66 commented Jan 8, 2025

Thank you for the quick fix! Much appreciated. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant