From b478106f694491d84fd2f211e34b7db09e1c3e3d Mon Sep 17 00:00:00 2001 From: jaw <2135326728@qq.com> Date: Tue, 27 Jun 2023 10:05:33 +0800 Subject: [PATCH] fix: no output error when network error --- src/commands/check/index.ts | 20 ++++++++++---------- src/commands/check/render.ts | 7 +++++++ 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/commands/check/index.ts b/src/commands/check/index.ts index f832131..9641621 100644 --- a/src/commands/check/index.ts +++ b/src/commands/check/index.ts @@ -11,7 +11,7 @@ import type { import { CheckPackages } from '../../api/check' import { writePackage } from '../../io/packages' import { promptInteractive } from './interactive' -import { renderPackages } from './render' +import { outputErr, renderPackages } from './render' export async function check(options: CheckOptions) { let exitCode = 0 @@ -50,14 +50,18 @@ export async function check(options: CheckOptions) { if (options.interactive) resolvePkgs = await promptInteractive(resolvePkgs, options) + const { lines, errLines } = renderPackages(resolvePkgs, options) + const hasChanges = resolvePkgs.length && resolvePkgs.some(i => i.resolved.some(j => j.update)) if (!hasChanges) { - console.log(c.green('dependencies are already up-to-date')) + if (errLines.length) + outputErr(errLines) + else + console.log(c.green('dependencies are already up-to-date')) + return exitCode } - const { lines, errLines } = renderPackages(resolvePkgs, options) - console.log(lines.join('\n')) if (!options.all) { @@ -77,12 +81,8 @@ export async function check(options: CheckOptions) { console.log(c.green(`dependencies are already up-to-date in ${last} packages\n`)) } - if (errLines.length) { - console.error(c.inverse(c.red(c.bold(' ERROR ')))) - console.error() - console.error(errLines.join('\n')) - console.error() - } + if (errLines.length) + outputErr(errLines) if (options.interactive && !options.write) { options.write = await prompts([ diff --git a/src/commands/check/render.ts b/src/commands/check/render.ts index 0d5010b..0aef5ef 100644 --- a/src/commands/check/render.ts +++ b/src/commands/check/render.ts @@ -131,6 +131,13 @@ function renderResolveError(dep: ResolvedDepChange) { return lines } +export function outputErr(errLines: string[]) { + console.error(c.inverse(c.red(c.bold(' ERROR ')))) + console.error() + console.error(errLines.join('\n')) + console.error() +} + export function renderPackages(resolvePkgs: PackageMeta[], options: CheckOptions) { const lines: string[] = [''] const errLines: string[] = []