Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): Channel Reuse #499

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(primitives): Channel Reuse #499

merged 1 commit into from
Sep 6, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 5, 2024 •
edited
Loading

Description

Re-use op-alloy-protocol channel and block types.

Closes #488

@refcell refcell changed the title feat(primitives): reuse op-alloy-protocol channel and block types feat(primitives): Channel Reuse Sep 5, 2024
@refcell Graphite App
Copy link
Collaborator Author

refcell commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby September 5, 2024 19:42
@refcell refcell added A-primitives K-documentation Kind: documentation K-chore Kind: chore labels Sep 5, 2024 — with Graphite App
@refcell refcell removed the K-documentation Kind: documentation label Sep 5, 2024
@refcell refcell marked this pull request as ready for review September 5, 2024 19:42
@refcell refcell self-assigned this Sep 5, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.4%. Comparing base (d45b295) to head (c830879).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/derive/src/stages/channel_bank.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clabby
clabby approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we like deleting (moving) code

@refcell refcell added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 829b674 Sep 6, 2024
15 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 6, 2024
Closed
This was referenced Sep 21, 2024
Closed
Closed
This was referenced Oct 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 13, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(primitives): Remove Channel Type
2 participants
@refcell @clabby